Messages in this thread | | | Subject | Re: [PATCH 1/2] Compiler Attributes: add support for __fallthrough (gcc >= 7.1) | From | Bernd Petrovitsch <> | Date | Mon, 22 Oct 2018 12:45:03 +0200 |
| |
On 22/10/18 12:27, Dan Carpenter wrote: [...] > What does that even mean? Use both the attribute and the comment until > Eclipse is updated? > > case 3: > frob(); > __fall_through; /* fall through */ > case 4: > > That seems like a wrong idea...
It's more like ---- snip ---- case 3: frob(); __fall_through; /* no break - fall through */ case 4: ---- snip ---- as "eclipse" doesn't accept anything else.
And yes, it's far from "beautiful" but I hadn't time to dig into eclipses innards to fix that.
MfG, Bernd -- "I dislike type abstraction if it has no real reason. And saving on typing is not a good reason - if your typing speed is the main issue when you're coding, you're doing something seriously wrong." - Linus Torvalds [unhandled content-type:application/pgp-keys] | |