Messages in this thread | | | Subject | Re: [PATCH v5 3/3] clk: meson: add sub MMC clock controller driver | From | Jianxin Pan <> | Date | Mon, 22 Oct 2018 13:59:18 +0800 |
| |
On 2018/10/20 2:03, Stephen Boyd wrote: > Quoting Jianxin Pan (2018-10-19 09:12:53) >> On 2018/10/19 1:13, Stephen Boyd wrote: >>> Quoting Jianxin Pan (2018-10-17 22:07:25) >>>> diff --git a/drivers/clk/meson/clk-regmap.c b/drivers/clk/meson/clk-regmap.c >>>> index 305ee30..f96314d 100644 >>>> --- a/drivers/clk/meson/clk-regmap.c >>>> +++ b/drivers/clk/meson/clk-regmap.c >>>> @@ -113,8 +113,25 @@ static int clk_regmap_div_set_rate(struct clk_hw *hw, unsigned long rate, >>>> clk_div_mask(div->width) << div->shift, val); >>>> }; >>>> >>>> -/* Would prefer clk_regmap_div_ro_ops but clashes with qcom */ >>>> +static void clk_regmap_div_init(struct clk_hw *hw) >>>> +{ >>>> + struct clk_regmap *clk = to_clk_regmap(hw); >>>> + struct clk_regmap_div_data *div = clk_get_regmap_div_data(clk); >>>> + unsigned int val; >>>> + int ret; >>>> + >>>> + ret = regmap_read(clk->map, div->offset, &val); >>>> + if (ret) >>>> + return; >>>> >>>> + val &= (clk_div_mask(div->width) << div->shift); >>>> + if (!val) >>>> + regmap_update_bits(clk->map, div->offset, >>>> + clk_div_mask(div->width) << div->shift, >>>> + clk_div_mask(div->width)); >>>> +} >>>> + >>>> +/* Would prefer clk_regmap_div_ro_ops but clashes with qcom */ >>> >>> We should add a patch to rename the symbol for qcom, i.e. >>> qcom_clk_regmap_div_ro_ops, and then any symbols in this directory >>> should be meson_clk_regmap_div_ro_ops. >> "/* Would prefer clk_regmap_div_ro_ops but clashes with qcom */" >> This comment is not introduced in this patch. >> I followed the naming style in this file and add clk_regmap_divider_with_init_ops. >> >> @Jerome, What's your suggestion about this? > > Yes you don't need to fix anything in this series. Just saying that in > the future we should work on cleaning this up. > OK. Thank you! > . >
| |