Messages in this thread |  | | Date | Sun, 21 Oct 2018 10:31:59 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH v2 2/3] leds: upboard: Add LED support |
| |
On Sat 2018-10-20 14:17:58, Andy Shevchenko wrote: 1;2802;0c> On Fri, Oct 19, 2018 at 8:27 PM Dan O'Donovan <dan@emutex.com> wrote: > > > > From: Javier Arteaga <javier@emutex.com> > > > > Allow userspace to use the on-board LEDs as "upboard:<color>:". > > > > > +#include <linux/kernel.h> > > +#include <linux/leds.h> > > +#include <linux/mfd/upboard.h> > > +#include <linux/module.h> > > +#include <linux/platform_device.h> > > +#include <linux/regmap.h> > > +#include <linux/acpi.h> > > For better maintenance keep this ordered.
This is good as-is.
Pavel
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] |  |