Messages in this thread | | | Subject | Re: [PATCH] block: don't check position contiguity for DISCARD in attempt_merge | From | "jianchao.wang" <> | Date | Sat, 20 Oct 2018 21:57:44 +0800 |
| |
Hi Martin
On 10/19/18 11:57 PM, Martin K. Petersen wrote: > > Jianchao, > >> Discard command supports multiple ranges of blocks, so needn't >> checking position contiguity when merging. Let's do the same thing >> in attempt_merge as the blk_try_merge. > > Discards need to be contiguous unless queue->limits.max_discard_segments > is bigger than 1. So if you remove this I think you need to add a > contiguity check in req_attempt_discard_merge(). > Yes.
I will send the V2 version next.
Thanks Jianchao
| |