lkml.org 
[lkml]   [2018]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] block: don't check position contiguity for DISCARD in attempt_merge
From
Date
Hi Martin

On 10/19/18 11:57 PM, Martin K. Petersen wrote:
>
> Jianchao,
>
>> Discard command supports multiple ranges of blocks, so needn't
>> checking position contiguity when merging. Let's do the same thing
>> in attempt_merge as the blk_try_merge.
>
> Discards need to be contiguous unless queue->limits.max_discard_segments
> is bigger than 1. So if you remove this I think you need to add a
> contiguity check in req_attempt_discard_merge().
>
Yes.

I will send the V2 version next.

Thanks
Jianchao

\
 
 \ /
  Last update: 2018-10-20 15:58    [W:0.044 / U:1.780 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site