Messages in this thread | | | Date | Fri, 19 Oct 2018 23:28:44 +0300 | From | Ivan Khoronzhuk <> | Subject | Re: [PATCH net-next] net: ethernet: ti: cpsw: don't flush mcast entries while switch promisc mode |
| |
Grygorii,
On Fri, Oct 19, 2018 at 10:24:55PM +0300, Ivan Khoronzhuk wrote: >On Fri, Oct 19, 2018 at 12:23:28PM -0500, Grygorii Strashko wrote: >> >> >>On 10/19/18 7:04 AM, Ivan Khoronzhuk wrote: >>>On Thu, Oct 18, 2018 at 07:03:06PM -0500, Grygorii Strashko wrote: >>>> >>>> >>>>On 10/18/18 1:00 PM, Ivan Khoronzhuk wrote: >>>>>No need now to flush mcast entries in switch mode while toggling to >>>>>promiscuous mode. It's not needed as vlan reg_mcast = ALL_PORTS >>>>>and mcast/vlan ports = ALL_PORTS, the same happening for vlan >>>>>unreg_mcast, it's set to ALL_PORT_MASK just after calling promisc >>>>>mode routine by calling set allmulti. I suppose main reason to flush >>>>>them is to use unreg_mcast to receive all to host port. Thus, now, all >>>>>mcast packets are received anyway and no reason to flush mcast entries >>>>>unsafely, as they were synced with __dev_mc_sync() previously and are >>>>>not restored. Another way is to _dev_mc_unsync() them, but no need.
I've sent new patch achiving the same but with second viariant described in this cover letter. Please, look at it. No rush.
-- Regards, Ivan Khoronzhuk
| |