lkml.org 
[lkml]   [2018]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] x86/earlyprintk: Add a force option for pciserial device
Hi Boris,

On Mon, Oct 01, 2018 at 10:30:04PM +0200, Borislav Petkov wrote:
> On Mon, Oct 01, 2018 at 10:18:10PM +0800, Feng Tang wrote:
> > As I rechecked, the baud rate for pciserial is optional, so there may
> > be no ",baudrate" following the "force". So this 2 strncmp is to
> > cover conditions for with and without baudrate.
>
> And what guarantees you have a space after the "force"?
>
> !strncmp(s, "force ", 6)
> ^

You are right, it can't be guranteed. Can we still use strncmp(s, "force", 5)
and rely on developer to set it right? any suggestions? thanks,

- Feng

\
 
 \ /
  Last update: 2018-10-02 11:11    [W:0.083 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site