lkml.org 
[lkml]   [2018]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.18 008/228] net: hns3: Fix for mac pause not disable in pfc mode
    Date
    4.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Yunsheng Lin <linyunsheng@huawei.com>

    [ Upstream commit 6d0ec65cb5810f9bf08671be008785bb8c84d39f ]

    When pfc pause mode is enable, the mac pause mode need to be
    disabled, otherwise the pfc pause packet will not be sent when
    congestion happens.

    This patch fixes by disabling the mac pause when pfc pause is
    enabled.

    Fixes: 848440544b41 ("net: hns3: Add support of TX Scheduler & Shaper to HNS3 driver")
    Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
    Signed-off-by: Peng Li <lipeng321@huawei.com>
    Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c | 9 +++++++--
    1 file changed, 7 insertions(+), 2 deletions(-)

    --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c
    +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c
    @@ -1223,6 +1223,10 @@ static int hclge_mac_pause_setup_hw(stru
    tx_en = true;
    rx_en = true;
    break;
    + case HCLGE_FC_PFC:
    + tx_en = false;
    + rx_en = false;
    + break;
    default:
    tx_en = true;
    rx_en = true;
    @@ -1240,8 +1244,9 @@ int hclge_pause_setup_hw(struct hclge_de
    if (ret)
    return ret;

    - if (hdev->tm_info.fc_mode != HCLGE_FC_PFC)
    - return hclge_mac_pause_setup_hw(hdev);
    + ret = hclge_mac_pause_setup_hw(hdev);
    + if (ret)
    + return ret;

    /* Only DCB-supported dev supports qset back pressure and pfc cmd */
    if (!hnae3_dev_dcb_supported(hdev))

    \
     
     \ /
      Last update: 2018-10-02 16:13    [W:2.159 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site