lkml.org 
[lkml]   [2018]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.18 116/228] gpio: Fix wrong rounding in gpio-menz127
    Date
    4.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Nadav Amit <namit@vmware.com>

    [ Upstream commit 7279d9917560bbd0d82813d6bf00490a82c06783 ]

    men_z127_debounce() tries to round up and down, but uses functions which
    are only suitable when the divider is a power of two, which is not the
    case. Use the appropriate ones.

    Found by static check. Compile tested.

    Fixes: f436bc2726c64 ("gpio: add driver for MEN 16Z127 GPIO controller")
    Signed-off-by: Nadav Amit <namit@vmware.com>
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/gpio/gpio-menz127.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/gpio/gpio-menz127.c
    +++ b/drivers/gpio/gpio-menz127.c
    @@ -56,9 +56,9 @@ static int men_z127_debounce(struct gpio
    rnd = fls(debounce) - 1;

    if (rnd && (debounce & BIT(rnd - 1)))
    - debounce = round_up(debounce, MEN_Z127_DB_MIN_US);
    + debounce = roundup(debounce, MEN_Z127_DB_MIN_US);
    else
    - debounce = round_down(debounce, MEN_Z127_DB_MIN_US);
    + debounce = rounddown(debounce, MEN_Z127_DB_MIN_US);

    if (debounce > MEN_Z127_DB_MAX_US)
    debounce = MEN_Z127_DB_MAX_US;

    \
     
     \ /
      Last update: 2018-10-02 16:07    [W:9.552 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site