| From | Arnd Bergmann <> | Date | Wed, 17 Oct 2018 17:02:33 +0200 | Subject | Re: [PATCH V9 05/21] csky: System Call |
| |
On Tue, Oct 16, 2018 at 5:01 AM Guo Ren <ren_guo@c-sky.com> wrote: > > This patch adds files related to syscall. > > Signed-off-by: Guo Ren <ren_guo@c-sky.com> > Cc: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
I had a detailed look at this one and provided lots of comments, however one tiny thing escaped me:
> +#define __NR_set_thread_area (__NR_arch_specific_syscall + 0) > +__SYSCALL(__NR_set_thread_area, sys_set_thread_area) > +#define __NR_cacheflush (__NR_arch_specific_syscall + 4) > +__SYSCALL(__NR_cacheflush, sys_cacheflush)
It's odd that the second one uses __NR_arch_specific_syscall + 4 rather than +1. If you can still change that changing too much other stuff, that might avoid some head-scratching later. If it causes problems, just leave it and maybe add a comment saying that the numbers inbetween are still available.
Arnd
|