Messages in this thread | | | From | Miguel Ojeda <> | Date | Mon, 15 Oct 2018 23:14:57 +0200 | Subject | Re: [PATCH] compiler.h: update definition of unreachable() |
| |
On Mon, Oct 15, 2018 at 10:13 PM Nick Desaulniers <ndesaulniers@google.com> wrote: > > Looking at commit cb984d101b30 ("compiler-gcc: integrate the various > compiler-gcc[345].h files") it seems that the comment is referring to > gcc 4.4 not supporting __builtin_unreachable(). Looks like it was > added in 4.5 timeframe: https://godbolt.org/z/ugv5QO, so the comment > can be deleted. Would you prefer a v2 (single patch), or an > additional patch on top?
Split would be better, I think, since the changes can be applied independetly even if related. If you are busy, I can do it myself, so don't worry too much. :)
Cheers, Miguel
| |