lkml.org 
[lkml]   [2018]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.18 015/100] drm/i2c: tda9950: set MAX_RETRIES for errors only
    Date
    From: Hans Verkuil <hverkuil@xs4all.nl>

    [ Upstream commit e0dccce1193f87597548d0db6ecc942fb92c04cd ]

    The CEC_TX_STATUS_MAX_RETRIES should be set for errors only to
    prevent the CEC framework from retrying the transmit. If the
    transmit was successful, then don't set this flag.

    Found by running 'cec-compliance -A' on a beaglebone box.

    Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
    Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/i2c/tda9950.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/i2c/tda9950.c b/drivers/gpu/drm/i2c/tda9950.c
    index f2186409f0cf..ccd355d0c123 100644
    --- a/drivers/gpu/drm/i2c/tda9950.c
    +++ b/drivers/gpu/drm/i2c/tda9950.c
    @@ -188,7 +188,8 @@ static irqreturn_t tda9950_irq(int irq, void *data)
    break;
    }
    /* TDA9950 executes all retries for us */
    - tx_status |= CEC_TX_STATUS_MAX_RETRIES;
    + if (tx_status != CEC_TX_STATUS_OK)
    + tx_status |= CEC_TX_STATUS_MAX_RETRIES;
    cec_transmit_done(priv->adap, tx_status, arb_lost_cnt,
    nack_cnt, 0, err_cnt);
    break;
    --
    2.17.1
    \
     
     \ /
      Last update: 2018-10-16 06:37    [W:4.022 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site