lkml.org 
[lkml]   [2018]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.14 25/61] qed: Avoid implicit enum conversion in qed_set_tunn_cls_info
    Date
    From: Nathan Chancellor <natechancellor@gmail.com>

    [ Upstream commit a898fba32229efd5e6b6154f83fa86a7145156b9 ]

    Clang warns when one enumerated type is implicitly converted to another.

    drivers/net/ethernet/qlogic/qed/qed_sp_commands.c:163:25: warning:
    implicit conversion from enumeration type 'enum tunnel_clss' to
    different enumeration type 'enum qed_tunn_clss' [-Wenum-conversion]
    p_tun->vxlan.tun_cls = type;
    ~ ^~~~
    drivers/net/ethernet/qlogic/qed/qed_sp_commands.c:165:26: warning:
    implicit conversion from enumeration type 'enum tunnel_clss' to
    different enumeration type 'enum qed_tunn_clss' [-Wenum-conversion]
    p_tun->l2_gre.tun_cls = type;
    ~ ^~~~
    drivers/net/ethernet/qlogic/qed/qed_sp_commands.c:167:26: warning:
    implicit conversion from enumeration type 'enum tunnel_clss' to
    different enumeration type 'enum qed_tunn_clss' [-Wenum-conversion]
    p_tun->ip_gre.tun_cls = type;
    ~ ^~~~
    drivers/net/ethernet/qlogic/qed/qed_sp_commands.c:169:29: warning:
    implicit conversion from enumeration type 'enum tunnel_clss' to
    different enumeration type 'enum qed_tunn_clss' [-Wenum-conversion]
    p_tun->l2_geneve.tun_cls = type;
    ~ ^~~~
    drivers/net/ethernet/qlogic/qed/qed_sp_commands.c:171:29: warning:
    implicit conversion from enumeration type 'enum tunnel_clss' to
    different enumeration type 'enum qed_tunn_clss' [-Wenum-conversion]
    p_tun->ip_geneve.tun_cls = type;
    ~ ^~~~
    5 warnings generated.

    Avoid this by changing type to an int.

    Link: https://github.com/ClangBuiltLinux/linux/issues/125
    Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/qlogic/qed/qed_sp_commands.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/qlogic/qed/qed_sp_commands.c b/drivers/net/ethernet/qlogic/qed/qed_sp_commands.c
    index 46d0c3cb83a5..d7c5965328be 100644
    --- a/drivers/net/ethernet/qlogic/qed/qed_sp_commands.c
    +++ b/drivers/net/ethernet/qlogic/qed/qed_sp_commands.c
    @@ -154,7 +154,7 @@ qed_set_pf_update_tunn_mode(struct qed_tunnel_info *p_tun,
    static void qed_set_tunn_cls_info(struct qed_tunnel_info *p_tun,
    struct qed_tunnel_info *p_src)
    {
    - enum tunnel_clss type;
    + int type;

    p_tun->b_update_rx_cls = p_src->b_update_rx_cls;
    p_tun->b_update_tx_cls = p_src->b_update_tx_cls;
    --
    2.17.1
    \
     
     \ /
      Last update: 2018-10-16 06:27    [W:4.078 / U:0.500 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site