lkml.org 
[lkml]   [2018]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.14 40/61] smsc95xx: Check for Wake-on-LAN modes
    Date
    From: Florian Fainelli <f.fainelli@gmail.com>

    [ Upstream commit c530c471ba37bdd9fe1c7185b01455c00ae606fb ]

    The driver does not check for Wake-on-LAN modes specified by an user,
    but will conditionally set the device as wake-up enabled or not based on
    that, which could be a very confusing user experience.

    Fixes: e0e474a83c18 ("smsc95xx: add wol magic packet support")
    Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/usb/smsc95xx.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
    index 309b88acd3d0..99e684e39d35 100644
    --- a/drivers/net/usb/smsc95xx.c
    +++ b/drivers/net/usb/smsc95xx.c
    @@ -774,6 +774,9 @@ static int smsc95xx_ethtool_set_wol(struct net_device *net,
    struct smsc95xx_priv *pdata = (struct smsc95xx_priv *)(dev->data[0]);
    int ret;

    + if (wolinfo->wolopts & ~SUPPORTED_WAKE)
    + return -EINVAL;
    +
    pdata->wolopts = wolinfo->wolopts & SUPPORTED_WAKE;

    ret = device_set_wakeup_enable(&dev->udev->dev, pdata->wolopts);
    --
    2.17.1
    \
     
     \ /
      Last update: 2018-10-16 06:26    [W:4.093 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site