lkml.org 
[lkml]   [2018]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.14 38/61] r8152: Check for supported Wake-on-LAN Modes
    Date
    From: Florian Fainelli <f.fainelli@gmail.com>

    [ Upstream commit f2750df1548bd8a2b060eb609fc43ca82811af4c ]

    The driver does not check for Wake-on-LAN modes specified by an user,
    but will conditionally set the device as wake-up enabled or not based on
    that, which could be a very confusing user experience.

    Fixes: 21ff2e8976b1 ("r8152: support WOL")
    Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/usb/r8152.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
    index 0fa64cc1a011..66beff4d7646 100644
    --- a/drivers/net/usb/r8152.c
    +++ b/drivers/net/usb/r8152.c
    @@ -4497,6 +4497,9 @@ static int rtl8152_set_wol(struct net_device *dev, struct ethtool_wolinfo *wol)
    if (!rtl_can_wakeup(tp))
    return -EOPNOTSUPP;

    + if (wol->wolopts & ~WAKE_ANY)
    + return -EINVAL;
    +
    ret = usb_autopm_get_interface(tp->intf);
    if (ret < 0)
    goto out_set_wol;
    --
    2.17.1
    \
     
     \ /
      Last update: 2018-10-16 06:25    [W:4.067 / U:0.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site