lkml.org 
[lkml]   [2018]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: Can we just remove the sw_lpm_support from current xhci driver?
Date
Hi Mathias:

>-----Original Message-----
>From: Mathias Nyman [mailto:mathias.nyman@intel.com]
>Sent: Monday, October 15, 2018 8:11 PM
>To: Zengtao (B) <prime.zeng@hisilicon.com>; Greg KH
><gregkh@linuxfoundation.org>
>Cc: linux-kernel@vger.kernel.org; linux-usb@vger.kernel.org
>Subject: Re: Can we just remove the sw_lpm_support from current xhci
>driver?
>
>On 15.10.2018 12:35, Zengtao (B) wrote:
>> Hi:
>>
>> I am recently reading the LPM related code in xhci driver, and I find
>> that the xhci->sw_lpm_support is not really used, but I am not sure
>> whether we should remove it or not?
>>
>> Any ideas, Thanks.
>
>I think it was used to prevent LPM in pre-0.96 xHC controllers.
>Now driver only supports HW LPM for 1.0 and later controllers, so
>xhci->sw_lpm_support doesn't really do anything.
>
>You can send a patch removing it
>
Ok, I will send a patch to do it, thanks.

>Thanks
>-Mathias
\
 
 \ /
  Last update: 2018-10-16 05:24    [W:0.034 / U:0.996 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site