lkml.org 
[lkml]   [2018]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH] x86: ptrace: Add function argument access API
On Mon, 15 Oct 2018 23:56:46 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:

> This patch looks good to me.
> But if the concern is real, all regs_get_kernel_stack_nth() user must move
> onto _safe() version, at least all tracers code.

Doing a git grep on regs_get_kernel_stack_nth(), I think you are right.
I'll resend and make the _nth() function just the _safe() function. No
need to do it without the probe_kernel_read() call.

>
> Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>

Thanks,

-- Steve

>
>

\
 
 \ /
  Last update: 2018-10-16 21:01    [W:0.198 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site