Messages in this thread Patch in this message | | | Date | Tue, 16 Oct 2018 19:37:35 +0200 | From | "Gustavo A. R. Silva" <> | Subject | [PATCH net-next v3 2/2] net: phy: mscc: fix memory leak in vsc8574_config_pre_init |
| |
In case memory resources for *fw* were successfully allocated, release them before return.
Addresses-Coverity-ID: 1473968 ("Resource leak") Fixes: 00d70d8e0e78 ("net: phy: mscc: add support for VSC8574 PHY") Reviewed-by: Quentin Schulz <quentin.schulz@bootlin.com> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- Changes in v3: - Add Quentin's Reviewed-by to the commit log. - Post patch to netdev.
Changes in v2: - Jump to out label so all functions in the driver exit with the PHY set to access the standard page. Thanks to Quentin Schulz for pointing this out.
drivers/net/phy/mscc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/mscc.c b/drivers/net/phy/mscc.c index bff56c3..a2e59f4 100644 --- a/drivers/net/phy/mscc.c +++ b/drivers/net/phy/mscc.c @@ -1292,7 +1292,7 @@ static int vsc8574_config_pre_init(struct phy_device *phydev) dev_err(dev, "%s: failed to assert reset of micro\n", __func__); - return ret; + goto out; } } } else { -- 2.7.4
| |