lkml.org 
[lkml]   [2018]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 71/71] ipv4: frags: precedence bug in ip_expire()
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    (commit 70837ffe3085c9a91488b52ca13ac84424da1042 upstream)

    We accidentally removed the parentheses here, but they are required
    because '!' has higher precedence than '&'.

    Fixes: fa0f527358bd ("ip: use rb trees for IP frag queue.")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/ipv4/ip_fragment.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/net/ipv4/ip_fragment.c
    +++ b/net/ipv4/ip_fragment.c
    @@ -203,7 +203,7 @@ static void ip_expire(unsigned long arg)
    __IP_INC_STATS(net, IPSTATS_MIB_REASMFAILS);
    __IP_INC_STATS(net, IPSTATS_MIB_REASMTIMEOUT);

    - if (!qp->q.flags & INET_FRAG_FIRST_IN)
    + if (!(qp->q.flags & INET_FRAG_FIRST_IN))
    goto out;

    /* sk_buff::dev and sk_buff::rbnode are unionized. So we

    \
     
     \ /
      Last update: 2018-10-16 19:27    [W:4.028 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site