lkml.org 
[lkml]   [2018]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] scsi: hisi_sas: Fix spin lock management in slot_index_alloc_quirk_v2_hw()
    Date
    Currently a spin_unlock_irqrestore() call is missing on the error path, so
    add it.

    Reported-by: Julia Lawall <julia.lawall@lip6.fr>
    Signed-off-by: John Garry <john.garry@huawei.com>

    diff --git a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
    index 70d6b28..cc36b64 100644
    --- a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
    +++ b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
    @@ -806,8 +806,10 @@ static u32 hisi_sas_phy_read32(struct hisi_hba *hisi_hba,
    while (1) {
    start = find_next_zero_bit(bitmap,
    hisi_hba->slot_index_count, start);
    - if (start >= end)
    + if (start >= end) {
    + spin_unlock_irqrestore(&hisi_hba->lock, flags);
    return -SAS_QUEUE_FULL;
    + }
    /*
    * SAS IPTT bit0 should be 1, and SATA IPTT bit0 should be 0.
    */
    --
    1.9.1
    \
     
     \ /
      Last update: 2018-10-16 16:59    [W:3.626 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site