Messages in this thread | | | From | Eric Anholt <> | Subject | Re: [PATCH 0/7] staging: vc04_services: Some dead code removal | Date | Mon, 15 Oct 2018 09:14:34 -0700 |
| |
Stefan Wahren <stefan.wahren@i2se.com> writes:
> Hi Tuomas, > >> Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi> hat am 4. Oktober 2018 um 11:37 geschrieben: >> >> >> Drop various pieces of dead code from here and there to get rid of >> the remaining users of VCHI_CONNECTION_T. After that we get to drop >> entire header files worth of unused code. >> >> I've tested on a Raspberry Pi Model B (bcm2835_defconfig) that >> snd-bcm2835 can still play analog audio just fine. >> > > thanks and i'm fine with your patch series: > > Acked-by: Stefan Wahren <stefan.wahren@i2se.com> > > Unfortunately this would break compilation of the downstream vchi > drivers like vcsm [1]. Personally i don't want to maintain another > one, because i cannot see the gain of the resulting effort. > > [1] - https://github.com/raspberrypi/linux/tree/rpi-4.14.y/drivers/char/broadcom/vc_sm
I think the main concern would be if we removed things necessary for 6by9's new vcsm (the one that will let us do dma-buf sharing between media decode and DRM).
On the other hand, git revert is a thing, so it's not like we actually lose anything. [unhandled content-type:application/pgp-signature] | |