Messages in this thread | | | Subject | Re: [PATCH v2 2/3] mtd: rawnand: stm32_fmc2: add STM32 FMC2 NAND flash controller driver | From | Christophe Kerello <> | Date | Mon, 15 Oct 2018 10:09:49 +0200 |
| |
On 10/05/2018 11:58 AM, Boris Brezillon wrote: > On Fri, 5 Oct 2018 11:41:59 +0200 > <christophe.kerello@st.com> wrote: > >> +struct stm32_fmc2 { > > You should inherit from nand_controller even if the nand_chip already > embeds a dummy nand controller object. > > struct nand_controller base; >
Hi Boris,
Ok, i will add and handle the nand controller structure.
Regards, Christophe Kerello.
>> + struct stm32_fmc2_nand nand; >> + struct device *dev; >> + void __iomem *io_base; >> + void __iomem *data_base[FMC2_MAX_CE]; >> + void __iomem *cmd_base[FMC2_MAX_CE]; >> + void __iomem *addr_base[FMC2_MAX_CE]; >> + phys_addr_t io_phys_addr; >> + phys_addr_t data_phys_addr[FMC2_MAX_CE]; >> + struct clk *clk; >> + >> + struct dma_chan *dma_tx_ch; >> + struct dma_chan *dma_rx_ch; >> + struct dma_chan *dma_ecc_ch; >> + struct sg_table dma_data_sg; >> + struct sg_table dma_ecc_sg; >> + u8 *ecc_buf; >> + int dma_ecc_len; >> + >> + struct completion complete; >> + struct completion dma_data_complete; >> + struct completion dma_ecc_complete; >> + >> + u8 cs_assigned; >> + int cs_sel; >> +};
| |