Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Sun, 14 Oct 2018 12:55:57 +0200 | Subject | Re: [PATCH v2 5/6] esp_scsi: De-duplicate PIO routines |
| |
Hi Finn,
On Sun, Oct 14, 2018 at 8:35 AM Finn Thain <fthain@telegraphics.com.au> wrote: > As a temporary measure, the code to implement PIO transfers was > duplicated in zorro_esp and mac_esp. Now that it has stabilized > move the common code into the core driver but don't build it unless > needed. > > This replaces the inline assembler with more portable writesb() calls. > Optimizing the m68k writesb() implementation is a separate patch. > > Tested-by: Stan Johnson <userm57@yahoo.com> > Signed-off-by: Finn Thain <fthain@telegraphics.com.au> > Tested-by: Michael Schmitz <schmitzmic@gmail.com>
Thanks for your patch!
> --- a/drivers/scsi/Kconfig > +++ b/drivers/scsi/Kconfig > @@ -42,6 +42,10 @@ config SCSI_DMA > bool > default n > > +config SCSI_ESP_PIO > + bool > + default n
"default n" is the default, so please drop this line.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |