Messages in this thread | | | From | Chen-Yu Tsai <> | Date | Fri, 12 Oct 2018 18:03:42 +0800 | Subject | Re: [PATCH v3 2/2] drm/sun4i: tcon: prevent tcon->panel dereference if NULL |
| |
On Mon, Oct 8, 2018 at 5:21 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > On Fri, Oct 05, 2018 at 11:59:51PM +0200, Giulio Benetti wrote: > > If tcon->panel pointer is NULL, trying to dereference from it > > (i.e. tcon->panel->connector) will cause a null pointer dereference. > > > > Add tcon->panel null pointer check before calling > > sun4i_tcon0_mode_set_dithering(). > > > > Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com> > > Fixes: f11adcecbd5f ("drm/sun4i: tcon: Add dithering support for > > RGB565/RGB666 LCD panels") > > Reviewed-by: Chen-Yu Tsai <wens@csie.org> > > Applied both, thanks!
I think this one could have been applied to drm-misc-next-fixes, as the bug was only recently introduced.
We'll have to make sure it gets backported somehow.
ChenYu
| |