Messages in this thread | | | From | Arnd Bergmann <> | Date | Thu, 11 Oct 2018 09:03:51 +0200 | Subject | Re: [PATCH v3 4/6] parisc: uapi header and system call table file generation |
| |
On Thu, Oct 11, 2018 at 8:48 AM Firoz Khan <firoz.khan@linaro.org> wrote: > On Thu, 11 Oct 2018 at 11:40, Firoz Khan <firoz.khan@linaro.org> wrote: > > On Wed, 10 Oct 2018 at 01:48, Helge Deller <deller@gmx.de> wrote:
> > > + > > > +ENTRY(sys_call_table) > > > +#if defined(CONFIG_64BIT) > > > +#include <asm/syscall_table_c32.h> /* compat syscalls */ > > > +#else > > > +#include <asm/syscall_table_32.h> /* 32-bit native syscalls */ > > > +#endif > > > +END(sys_call_table) > > > + > > > #ifdef CONFIG_64BIT > > > -#define SYSCALL_TABLE_64BIT > > > -#include "syscall_table_64.S" > > > +ENTRY(sys_call_table64) > > > +#include <asm/syscall_table_64.h> /* 64-bit native syscalls */ > > > +END(sys_call_table64) > > > #endif > > > > > > /* > > I could see a patch (commit 47514da3ac20150cdf764466fbc2010c0fca0163) > which will perform a compile-check when adding a new syscall. My patches > will remove this feature. Is that fine?
I think it's ok: You are automating it so the bug can no longer happen, which is better than adding checks to prevent human errors.
Arnd
| |