lkml.org 
[lkml]   [2018]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 3/5] spi: pxa2xx: use an enum for type
    From
    Date
    On Fri, 2018-09-21 at 22:34 +0200, Robert Jarzmik wrote:
    > Lubomir Rintel <lkundrak@v3.sk> writes:
    >
    > > That seems to be the correct type.
    > Okay, but what happens here when adev_id->driver_data is a value out
    > of enum
    > range ? Does the following assignment make sense ?
    > > + type = (enum pxa_ssp_type)adev_id->driver_data;
    >
    > As a side note, could you join for the next throw to the review :
    > - Jarkko Nikula <jarkko.nikula@linux.intel.com>
    > - Mika Westerberg <mika.westerberg@linux.intel.com>

    Argh, of course I forgot. My apologies.

    Jarkko & Mika, I'm wondering if you could take a look at the [1] thread
    and tell me what you think. (I can forward it to you via e-mail too, if
    you're not subscribed to lists it has been Cc'd to, if that would be
    more convenient).

    [1] [PATCH 0/11] spi: pxa2xx: add DT and slave mode support"
    https://lore.kernel.org/lkml/20181010170936.316862-1-lkundrak@v3.sk/T/#t

    Thanks
    Lubo

    >
    > Even if they are Intel, I think they have worked a lot on this driver
    > for Intel
    > platforms.
    >
    > Cheers.
    >

    \
     
     \ /
      Last update: 2018-10-10 19:27    [W:2.952 / U:1.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site