Messages in this thread | | | Subject | Re: [PATCH v2 1/2] net/ncsi: Add NCSI Broadcom OEM command | From | Samuel Mendoza-Jonas <> | Date | Wed, 10 Oct 2018 15:39:44 +1100 |
| |
On Tue, 2018-10-09 at 10:48 -0700, Vijay Khemka wrote: > This patch adds OEM Broadcom commands and response handling. It also > defines OEM Get MAC Address handler to get and configure the device. > > ncsi_oem_gma_handler_bcm: This handler send NCSI broadcom command for > getting mac address. > ncsi_rsp_handler_oem_bcm: This handles response received for all > broadcom OEM commands. > ncsi_rsp_handler_oem_bcm_gma: This handles get mac address response and > set it to device. > > Signed-off-by: Vijay Khemka <vijaykhemka@fb.com> > --- > net/ncsi/Kconfig | 6 ++++ > net/ncsi/internal.h | 8 +++++ > net/ncsi/ncsi-manage.c | 70 +++++++++++++++++++++++++++++++++++++++++- > net/ncsi/ncsi-pkt.h | 8 +++++ > net/ncsi/ncsi-rsp.c | 40 +++++++++++++++++++++++- > 5 files changed, 130 insertions(+), 2 deletions(-) >
<snip>
> static void ncsi_configure_channel(struct ncsi_dev_priv *ndp) > { > struct ncsi_dev *nd = &ndp->ndev; > @@ -643,9 +676,10 @@ static void ncsi_configure_channel(struct ncsi_dev_priv *ndp) > struct ncsi_channel *nc = ndp->active_channel; > struct ncsi_channel *hot_nc = NULL; > struct ncsi_cmd_arg nca; > + struct ncsi_oem_gma_handler *nch = NULL; > unsigned char index; > unsigned long flags; > - int ret; > + int ret, i; >
I just noticed that if CONFIG_NCSI_OEM_CMD_GET_MAC is not set then this generates unused variable warnings for i and nch. Otherwise all looking good!
Regards, Sam
| |