Messages in this thread | | | Subject | Re: [PATCH v2 1/2] arm/arm64: KVM: rename function kvm_arch_dev_ioctl_check_extension() | From | gengdongjiu <> | Date | Wed, 10 Oct 2018 10:29:48 +0800 |
| |
Hi Suzuki,
On 2018/10/10 0:34, Suzuki K Poulose wrote: > Hi, > > On 08/10/18 13:34, Dongjiu Geng wrote: >> Rename kvm_arch_dev_ioctl_check_extension() to >> kvm_arch_vm_ioctl_check_extension(), because it does >> not have any relationship with device. >> >> Renaming this function can make code readable. > > +1. The current name is not really intuitive. > >> >> Cc: James Morse <james.morse@arm.com> >> Signed-off-by: Dongjiu Geng <gengdongjiu@huawei.com> > > Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Thanks very much for the review
> > . >
| |