Messages in this thread | | | Subject | Re: [PATCH v2] rtlwifi: btcoex: Use proper enumerated types for Wi-Fi only interface | From | Kalle Valo <> | Date | Mon, 1 Oct 2018 15:37:09 +0000 (UTC) |
| |
Nathan Chancellor <natechancellor@gmail.com> wrote:
> Clang warns when one enumerated type is implicitly converted to another. > > drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c:1327:34: > warning: implicit conversion from enumeration type 'enum > btc_chip_interface' to different enumeration type 'enum > wifionly_chip_interface' [-Wenum-conversion] > wifionly_cfg->chip_interface = BTC_INTF_PCI; > ~ ^~~~~~~~~~~~ > drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c:1330:34: > warning: implicit conversion from enumeration type 'enum > btc_chip_interface' to different enumeration type 'enum > wifionly_chip_interface' [-Wenum-conversion] > wifionly_cfg->chip_interface = BTC_INTF_USB; > ~ ^~~~~~~~~~~~ > drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c:1333:34: > warning: implicit conversion from enumeration type 'enum > btc_chip_interface' to different enumeration type 'enum > wifionly_chip_interface' [-Wenum-conversion] > wifionly_cfg->chip_interface = BTC_INTF_UNKNOWN; > ~ ^~~~~~~~~~~~~~~~ > 3 warnings generated. > > Use the values from the correct enumerated type, wifionly_chip_interface. > > BTC_INTF_UNKNOWN = WIFIONLY_INTF_UNKNOWN = 0 > BTC_INTF_PCI = WIFIONLY_INTF_PCI = 1 > BTC_INTF_USB = WIFIONLY_INTF_USB = 2 > > Link: https://github.com/ClangBuiltLinux/linux/issues/135 > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Patch applied to wireless-drivers-next.git, thanks.
31138a827d1b rtlwifi: btcoex: Use proper enumerated types for Wi-Fi only interface
-- https://patchwork.kernel.org/patch/10611603/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
| |