lkml.org 
[lkml]   [2018]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 4/6] rpmsg: glink: Expose rpmsg name attr for glink
    From
    Date


    On 12/18/2017 2:48 PM, Stephen Boyd wrote:
    > On 12/18/2017 02:02 PM, Chris Lew wrote:
    >> Expose the name field as an attr so clients listening to uevents for
    >> rpmsg can identify the edge the events correspond to.
    >>
    >> Signed-off-by: Chris Lew <clew@codeaurora.org>
    >> ---
    >> drivers/rpmsg/qcom_glink_native.c | 18 ++++++++++++++++++
    >> 1 file changed, 18 insertions(+)
    >>
    >> diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c
    >> index 786f2eca01f1..a897ccea3098 100644
    >> --- a/drivers/rpmsg/qcom_glink_native.c
    >> +++ b/drivers/rpmsg/qcom_glink_native.c
    >> @@ -1558,6 +1558,22 @@ static void qcom_glink_work(struct work_struct *work)
    >> }
    >> }
    >>
    >> +static ssize_t rpmsg_name_show(struct device *dev,
    >> + struct device_attribute *attr, char *buf)
    >> +{
    >> + struct rpmsg_device *rpdev = to_rpmsg_device(dev);
    >> + struct qcom_glink_device *gdev = to_glink_device(rpdev);
    >> +
    >> + return snprintf(buf, RPMSG_NAME_SIZE, "%s\n", gdev->glink->name);
    >> +}
    >> +static DEVICE_ATTR_RO(rpmsg_name);
    >> +
    >> +static struct attribute *qcom_glink_attrs[] = {
    >
    > const?
    >

    Thanks Stephen, will change to "static const struct attribute *"

    --
    Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
    a Linux Foundation Collaborative Project

    \
     
     \ /
      Last update: 2018-01-14 23:20    [W:3.217 / U:0.428 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site