Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH] ath9k: add a quirk to set use_msi automatically | Date | Tue, 09 Jan 2018 09:29:14 +0200 |
| |
AceLan Kao <acelan.kao@canonical.com> writes:
> Some platform(BIOS) blocks legacy interrupts (INTx), and only allows MSI > for WLAN device. So adding a quirk to list those machines and set > use_msi automatically. > Adding the following platforms to the quirk. > Dell Inspiron 24-3460 > Dell Inspiron 3472 > Dell Inspiron 14-3473 > Dell Vostro 3262 > Dell Vostro 15-3572 > > Signed-off-by: AceLan Kao <acelan.kao@canonical.com>
[...]
> @@ -96,6 +97,56 @@ static const struct ieee80211_tpt_blink ath9k_tpt_blink[] = { > }; > #endif > > +static int __init set_use_msi(const struct dmi_system_id *dmi) > +{ > + ath9k_use_msi = 1; > + return 1; > +} > + > +static const struct dmi_system_id ath9k_quirks[] __initconst = { > + { > + .callback = set_use_msi, > + .ident = "Dell Inspiron 24-3460", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > + DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 24-3460"), > + }, > + },
Larry, didn't rtlwifi have similar situation that with certain laptops users were required to enable a module parameter to get the device working? I think rtlwifi should do the same as AceLan does here as then the user would not need to manually set the module parameter.
-- Kalle Valo
| |