Messages in this thread | | | Subject | Re: [PATCH v4 6/7] ARM: davinci: convert to common clock framework | From | Sekhar Nori <> | Date | Mon, 8 Jan 2018 11:06:36 +0530 |
| |
On Saturday 06 January 2018 07:12 AM, David Lechner wrote: > On 01/05/2018 04:42 AM, Sekhar Nori wrote: >> On Friday 05 January 2018 08:29 AM, David Lechner wrote: >>> On 01/04/2018 11:50 AM, David Lechner wrote: >>>> On 1/4/18 6:39 AM, Sekhar Nori wrote: >> >>>>> This is a pretty huge patch again and I hope it can be broken down. >>>>> Ideally one per SoC converted and then the unused code removal. >>>>> >>>> >>>> Will do. >>> >>> Well, I can do this, but I don't think it will compile or run. We can't >>> have the common clock framework and the legacy davinci clocks enabled at >>> the same time. >> >> I see. Can you at least hive off the code removal into a separate patch >> for next submission. I will then take a closer look at this. >> > > I've realized that I can accomplish this if I use some #if 0/#endif blocks > temporarily if that sounds OK.
I haven't looked at your latest submission, but this wont be acceptable. Even as a temporary measure.
If the patch cannot be broken down any, thats fine. I just wanted to explore the possibility to ease review.
Thanks, Sekhar
| |