Messages in this thread | | | Date | Mon, 8 Jan 2018 09:12:34 -0800 | From | Tejun Heo <> | Subject | Re: [PATCH 1/7] blk-mq: protect completion path with RCU |
| |
Hello, Christoph.
On Fri, Dec 29, 2017 at 02:04:18AM -0800, Christoph Hellwig wrote: > Why do you need the srcu protection? The completion path can never > sleep. > > If there is a good reason to keep it please add commment, and > make the srcu variant a separate function only used by drivers that > need it instead of adding the conditional.
It's either that or adding protection against both srcu and rcu in the counterpart. It's easier / cleaner to just use single rcu construct for a given queue. Will add a comment. Jens already has a patch which factors out the conditionals.
Thanks.
-- tejun
| |