Messages in this thread | | | Date | Mon, 8 Jan 2018 16:39:56 +0100 | From | Greg KH <> | Subject | Re: [PATCH] Staging: vme: vme_user: removed unnecessary parentheses |
| |
On Thu, Dec 28, 2017 at 11:15:30PM +0100, Philippe Loctaux wrote: > Removed unnecessary parentheses in the if statement. > > Signed-off-by: Philippe Loctaux <loctauxphilippe@gmail.com> > --- > drivers/staging/vme/devices/vme_user.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c > index 41a5b32e0..611ea219f 100644 > --- a/drivers/staging/vme/devices/vme_user.c > +++ b/drivers/staging/vme/devices/vme_user.c > @@ -511,7 +511,7 @@ static int vme_user_match(struct vme_dev *vdev) > int cur_slot = vme_slot_num(vdev); > > for (i = 0; i < bus_num; i++) > - if ((cur_bus == bus[i]) && (cur_slot == vdev->num)) > + if (cur_bus == bus[i] && cur_slot == vdev->num)
Ick, horrid, no, now you have to look up what the order of == vs. && is, do you know it?
thanks,
greg k-h
| |