Messages in this thread | | | Date | Mon, 8 Jan 2018 15:45:56 +0100 | From | Johan Hovold <> | Subject | Re: [PATCH] Staging: greybus: Fix multiple checks for null pointers |
| |
On Mon, Jan 08, 2018 at 11:28:13AM +0530, Sumit Pundir wrote: > Fixes the following coding style issue as noted by checkpatch.pl > at multiple lines: > > Comparison to NULL could be written "!token" > > Signed-off-by: Sumit Pundir <pundirsumit11@gmail.com>
Since you're not really fixing anything here, besides silencing a checkpatch suggestion when run with the --strict option (or on staging code), I suggest you reword you commit summary (Subject) to, for example:
staging: greybus: camera: clean up NULL checks
or similar.
Note that I also added "camera" as a module prefix above.
Thanks, Johan
| |