Messages in this thread | | | Date | Mon, 08 Jan 2018 14:42:49 +0100 | From | haver <> | Subject | Re: [PATCH 1/3] GenWQE: Delete an error message for a failed memory allocation in genwqe_user_vmap() |
| |
On 2018-01-08 14:24, SF Markus Elfring wrote: >>> @@ -593,7 +593,6 @@ int genwqe_user_vmap(struct genwqe_dev *cd, >>> struct >>> dma_mapping *m, void *uaddr, >>> sizeof(struct page *) + >>> sizeof(dma_addr_t), >>> GFP_KERNEL); >>> if (!m->page_list) { >>> - dev_err(&pci_dev->dev, "err: alloc page_list >>> failed\n"); >> >> Are there different printouts which cover this? > > Is this error message redundant? > > >> I mean the debug printout is not appearing all the time, >> it must be enabled, if I remember correctly. > > Would you like to clarify corresponding configuration possibilities any > more? > > >> So why do you suggest to remove it? > > Can the Linux allocation failure report be sufficient for this use case > already? > > Regards, > Markus
According to Dans message in parallel, it should be redundant and I am fine with removing it.
Acked-by: Frank Haverkamp <haver@linux.vnet.ibm.com>
| |