Messages in this thread | | | Date | Sun, 7 Jan 2018 21:19:41 -0800 | From | Srikar Dronamraju <> | Subject | Re: [PATCH] trace_uprobe: Display correct offset in uprobe_events |
| |
* Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> [2018-01-06 11:12:46]:
> Recently, how the pointers being printed with %p has been changed > by commit ad67b74d2469 ("printk: hash addresses printed with %p"). > This is causing a regression while showing offset in the > uprobe_events file. Instead of %p, use %px to display offset. > > Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> > --- > kernel/trace/trace_uprobe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c > index 40592e7b3568..268029ae1be6 100644 > --- a/kernel/trace/trace_uprobe.c > +++ b/kernel/trace/trace_uprobe.c > @@ -608,7 +608,7 @@ static int probes_seq_show(struct seq_file *m, void *v) > > /* Don't print "0x (null)" when offset is 0 */ > if (tu->offset) { > - seq_printf(m, "0x%p", (void *)tu->offset); > + seq_printf(m, "0x%px", (void *)tu->offset); > } else { > switch (sizeof(void *)) { > case 4:
Looks good to me. Did you consider %pK instead of %px?
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
| |