Messages in this thread | | | Subject | Re: [PATCH v2] x86: xen: remove the use of VLAIS | From | Juergen Gross <> | Date | Mon, 8 Jan 2018 07:54:05 +0100 |
| |
On 06/01/18 22:39, Nick Desaulniers wrote: > Variable Length Arrays In Structs (VLAIS) is not supported by Clang, and > frowned upon by others. > > https://lkml.org/lkml/2013/9/23/500 > > Here, the VLAIS was used because the size of the bitmap returned from > xen_mc_entry() depended on possibly (based on kernel configuration) > runtime sized data. Rather than declaring args as a VLAIS then calling > sizeof on *args, we calculate the appropriate sizeof args manually. > Further, we can get rid of the #ifdef's and rely on num_possible_cpus() > (thanks to a helpful checkpatch warning from an earlier version of this > patch). > > Suggested-by: Juergen Gross <jgross@suse.com> > Signed-off-by: Nick Desaulniers <nick.desaulniers@gmail.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
| |