Messages in this thread Patch in this message | | | From | Xiongfeng Wang <> | Subject | [PATCH] scsi: mptfusion: use strlcpy() instead of strncpy() | Date | Mon, 8 Jan 2018 20:49:13 +0800 |
| |
From: Xiongfeng Wang <xiongfeng.wang@linaro.org>
gcc-8 reports
drivers/message/fusion/mptbase.c: In function 'mpt_display_event_info': ./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified bound 100 equals destination size [-Wstringop-truncation]
We need to use strlcpy() to make sure the dest string is nul-terminated.
Signed-off-by: Xiongfeng Wang <xiongfeng.wang@linaro.org> --- drivers/message/fusion/mptbase.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c index 7a93400..3c47888 100644 --- a/drivers/message/fusion/mptbase.c +++ b/drivers/message/fusion/mptbase.c @@ -7697,7 +7697,7 @@ static void seq_mpt_print_ioc_summary(MPT_ADAPTER *ioc, struct seq_file *m, int break; } if (ds) - strncpy(evStr, ds, EVENT_DESCR_STR_SZ); + strlcpy(evStr, ds, EVENT_DESCR_STR_SZ); devtprintk(ioc, printk(MYIOC_s_DEBUG_FMT -- 1.8.3.1
| |