lkml.org 
[lkml]   [2018]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] test_hexdump: use memcpy() to avoid warning print
Date
From: Xiongfeng Wang <xiongfeng.wang@linaro.org>

gcc-8 reports

lib/test_hexdump.c: In function 'test_hexdump_prepare_test.isra.0':
./include/linux/string.h:245:9: warning: '__builtin_strncpy' output truncated
copying between 0 and 32 bytes from a string of length 32 [-Wstringop-truncation]

Since we don't need to copy '\0' in the end of the string, we can just
use memcpy() to avoid this warning.

Signed-off-by: Xiongfeng Wang <xiongfeng.wang@linaro.org>
---
lib/test_hexdump.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/test_hexdump.c b/lib/test_hexdump.c
index 3f415d8..a495726 100644
--- a/lib/test_hexdump.c
+++ b/lib/test_hexdump.c
@@ -81,7 +81,7 @@ static void __init test_hexdump_prepare_test(size_t len, int rowsize,
const char *q = *result++;
size_t amount = strlen(q);

- strncpy(p, q, amount);
+ memcpy(p, q, amount);
p += amount;

*p++ = ' ';
@@ -95,7 +95,7 @@ static void __init test_hexdump_prepare_test(size_t len, int rowsize,
*p++ = ' ';
} while (p < test + rs * 2 + rs / gs + 1);

- strncpy(p, data_a, l);
+ memcpy(p, data_a, l);
p += l;
}

--
1.8.3.1
\
 
 \ /
  Last update: 2018-01-14 23:17    [W:2.545 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site