lkml.org 
[lkml]   [2018]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 5/5] clk: qcom: use divider_ro_round_rate helper
From
Date
On Fri, 2018-01-05 at 18:09 +0100, Jerome Brunet wrote:
> There is now an helper function to round the rate when the
> divider is read-only. Let's use it
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> drivers/clk/qcom/clk-regmap-divider.c | 19 ++++++-------------
> 1 file changed, 6 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/clk/qcom/clk-regmap-divider.c b/drivers/clk/qcom/clk-regmap-divider.c
> index 4e9b8c2c8980..114e36b97255 100644
> --- a/drivers/clk/qcom/clk-regmap-divider.c
> +++ b/drivers/clk/qcom/clk-regmap-divider.c
> @@ -28,22 +28,15 @@ static long div_round_ro_rate(struct clk_hw *hw, unsigned long rate,
> {
> struct clk_regmap_div *divider = to_clk_regmap_div(hw);
> struct clk_regmap *clkr = &divider->clkr;
> - u32 div;
> + u32 val;
> struct clk_hw *hw_parent = clk_hw_get_parent(hw);

forgot to remove this line.

>
> - regmap_read(clkr->regmap, divider->reg, &div);
> - div >>= divider->shift;
> - div &= BIT(divider->width) - 1;
> - div += 1;
> -
> - if (clk_hw_get_flags(hw) & CLK_SET_RATE_PARENT) {
> - if (!hw_parent)
> - return -EINVAL;
> -
> - *prate = clk_hw_round_rate(hw_parent, rate * div);
> - }
> + regmap_read(clkr->regmap, divider->reg, &val);
> + val >>= divider->shift;
> + val &= BIT(divider->width) - 1;
>
> - return DIV_ROUND_UP_ULL((u64)*prate, div);
> + return divider_ro_round_rate(hw, rate, prate, NULL, divider->width,
> + CLK_DIVIDER_ROUND_CLOSEST, val);
> }
>
> static long div_round_rate(struct clk_hw *hw, unsigned long rate,

\
 
 \ /
  Last update: 2018-01-14 23:17    [W:0.121 / U:3.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site