lkml.org 
[lkml]   [2018]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v1 4/6] dt-bindings: clock: mediatek: add "simple-mfd" in audsys documentation
    On Thu, Jan 04, 2018 at 03:44:20PM +0800, Ryder Lee wrote:
    > Add "simple-mfd" to support MFD device and add a compatible string for MT2701.
    >
    > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
    > ---
    > .../bindings/arm/mediatek/mediatek,audsys.txt | 21 +++++++++++++++------
    > 1 file changed, 15 insertions(+), 6 deletions(-)
    >
    > diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.txt b/Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.txt
    > index 9b8f578..6e97552 100644
    > --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.txt
    > +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.txt
    > @@ -6,17 +6,25 @@ The MediaTek AUDSYS controller provides various clocks to the system.
    > Required Properties:
    >
    > - compatible: Should be one of:
    > - - "mediatek,mt7622-audsys", "syscon"
    > + - "mediatek,mt2701-audsys", "syscon", "simple-mfd"
    > + - "mediatek,mt7622-audsys", "syscon", "simple-mfd"
    > - #clock-cells: Must be 1

    I don't think this is a simple-mfd. The AFE uses clocks created by its
    parent, right? So the parent should be probed first. You should have
    the parent instantiate the child nodes.

    > The AUDSYS controller uses the common clk binding from
    > Documentation/devicetree/bindings/clock/clock-bindings.txt
    > The available clocks are defined in dt-bindings/clock/mt*-clk.h.
    >
    > +See ../sound/mt2701-afe-pcm.txt for details about required subnode.
    > +
    > Example:
    >
    > -audsys: audsys@11220000 {
    > - compatible = "mediatek,mt7622-audsys", "syscon";
    > - reg = <0 0x11220000 0 0x1000>;
    > - #clock-cells = <1>;
    > -};
    > + audsys: audio-subsystem@11220000 {
    > + compatible = "mediatek,mt2701-audsys", "syscon", "simple-mfd";
    > + reg = <0 0x11220000 0 0x1000>;
    > + #clock-cells = <1>;
    > +
    > + afe: audio-controller {
    > + compatible = "mediatek,mt2701-audio";
    > + ...
    > + };
    > + };
    > --
    > 1.9.1
    >
    > --
    > To unsubscribe from this list: send the line "unsubscribe devicetree" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html

    \
     
     \ /
      Last update: 2018-01-05 20:03    [W:5.252 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site