Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Thu, 4 Jan 2018 09:33:25 +0100 | Subject | Re: [PATCH] of/fdt: Fix #ifdef dependency of early flattree declarations |
| |
Hi Fengguang,
On Thu, Jan 4, 2018 at 12:16 AM, kbuild test robot <lkp@intel.com> wrote: > I love your patch! Yet something to improve:
Thanks, I love your report!
> url: https://github.com/0day-ci/linux/commits/Geert-Uytterhoeven/of-fdt-Fix-ifdef-dependency-of-early-flattree-declarations/20180104-062259 > base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next > config: i386-randconfig-i0-201800 (attached as .config) > compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025 > reproduce: > # save the attached .config to linux build tree > make ARCH=i386 > > All errors (new ones prefixed by >>): > > drivers/tty/serial/earlycon.c: In function 'param_setup_earlycon': >>> drivers/tty/serial/earlycon.c:221:11: error: implicit declaration of function 'early_init_dt_scan_chosen_stdout' [-Werror=implicit-function-declaration] > return early_init_dt_scan_chosen_stdout(); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > cc1: some warnings being treated as errors
Bummer, of course the dummies should be provided based on complementary logic... Will fix in v2.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |