Messages in this thread | | | Date | Thu, 01 Feb 2018 09:49:18 +0900 | From | Andi Shyti <> | Subject | Re: [PATCH 7/8] Input: mms114 - add SPDX identifier |
| |
Hi Marcus,
> > > > - * Copyright (C) 2012 Samsung Electronics Co.Ltd > > > > - * Author: Joonyoung Shim <jy0922.shim@samsung.com> > > > > - * > > > > - * This program is free software; you can redistribute it and/or modify > > > > - * it under the terms of the GNU General Public License version 2 as > > > > - * published by the Free Software Foundation. > > > > - */ > > > > +// SPDX-License-Identifier: GPL-2.0 > > > > +// Samsung S6SY761 Touchscreen device driver > > > > I'm very sorry, but my distrcation will kill me one day. > > More coffee or sleep - your choice ;-)
I see that beer is not working, indeed :)
> > Is it possible to revert this patch or do you want me to send a > > fix? > > When you are on it; > > Change > MODULE_LICENSE("GPL"); > > to > MODULE_LICENSE("GPL v2"); > To match the former license text and SPDX-identifier. > > See include/linux/module.h: > * "GPL" [GNU Public License v2 or later] > * "GPL v2" [GNU Public License v2]
I haven't noticed that. I will fix it in a separate patch.
Thanks, Andi
| |