Messages in this thread | | | Date | Thu, 1 Feb 2018 00:32:36 +0000 | From | Alan Cox <> | Subject | Re: [PATCH] tcp_lp: use 64-bit arithmetic instead of 32-bit |
| |
On Wed, 31 Jan 2018 18:24:07 -0600 "Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote:
> Cast to s64 some variables and a macro in order to give the > compiler complete information about the proper arithmetic to > use. Notice that these elements are used in contexts that > expect expressions of type s64 (64 bits, signed). > > Currently such expression are being evaluated using 32-bit > arithmetic.
The question you need to ask is 'can it overflow 32bit maths', otherwise you are potentially making the system do extra work for no reason.
Alan
| |