Messages in this thread | | | From | Andy Shevchenko <> | Date | Wed, 31 Jan 2018 18:56:43 +0200 | Subject | Re: [PATCH] ASoC: codecs: Add support for AK5558 ADC driver |
| |
On Wed, Jan 31, 2018 at 6:20 PM, Fabio Estevam <festevam@gmail.com> wrote: > Hi Daniel,
Fabio, +1 to your review. It seems it repeats some of the points I made.
>> + ak5558->pdn_gpio = of_get_named_gpio(np, "ak5558,pdn-gpio", 0); > > It does not match the property in the binding doc: asahi-kasei,pdn-gpios
Btw, it must be simple "reset" as a widely used for the same purpose.
-- With Best Regards, Andy Shevchenko
| |