Messages in this thread | | | Subject | Re: [PATCH] x86/paravirt: Remove 'noreplace-paravirt' cmdline option | From | Juergen Gross <> | Date | Wed, 31 Jan 2018 06:59:01 +0100 |
| |
On 31/01/18 05:13, Josh Poimboeuf wrote: > The 'noreplace-paravirt' option disables paravirt patching, leaving the > original pv indirect calls in place. > > That's highly incompatible with retpolines, unless we want to uglify > paravirt even further and convert the paravirt calls to retpolines. > > As far as I can tell, the option doesn't seem to be useful for much > other than introducing surprising corner cases and making the kernel > vulnerable to Spectre v2. It was probably a debug option from the early > paravirt days. So just remove it. > > Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
| |