Messages in this thread | | | From | "Keith Packard" <> | Subject | Re: [PATCH] drm: Check for lessee in DROP_MASTER ioctl | Date | Tue, 30 Jan 2018 11:55:01 -0800 |
| |
Daniel Vetter <daniel@ffwll.ch> writes:
> On Thu, Jan 18, 2018 at 05:51:59PM -0800, Keith Packard wrote: >> Don't let a lessee control what the current DRM master is set to; >> that's the job of the "real" master. Otherwise, the lessee would >> disable all access to master operations for the owner and all lessees >> under it. >> >> This matches the same check made in the SET_MASTER ioctl. >> >> Signed-off-by: Keith Packard <keithp@keithp.com> > > Similar check for setmaster already exists, so looks all good. Do we have > an igt for all this? Iirc there was one floating around, but no idea > what's the status. Might also be good to resubmit them so i915 CI can run > the tests (now that the code has landed).
I've got IGT tests for leasing which have been posted to dri-devel but I don't think they've been reviewed. Looks like they could use some more test cases; I didn't catch this one until I was playing with my 'xlease' hack, which runs the X server on a leased FD.
> On the patch itself, minus lack of testcases: > > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Thanks!
-- -keith [unhandled content-type:application/pgp-signature] | |