Messages in this thread | | | From | Dongsu Park <> | Date | Tue, 30 Jan 2018 19:13:05 +0100 | Subject | Re: [RFC PATCH v3 2/2] ima: force re-appraisal on filesystems with FS_IMA_NO_CACHE |
| |
Hi,
On Mon, Jan 29, 2018 at 6:40 PM, Dongsu Park <dongsu@kinvolk.io> wrote: > On Mon, Jan 29, 2018 at 5:33 PM, Mimi Zohar <zohar@linux.vnet.ibm.com> wrote: >> On Thu, 2018-01-25 at 06:56 -0500, Mimi Zohar wrote: ... >> Did you get a chance to make the change and test it? > > Alban has been on holidays, so he will be back on Wednesday or so. > So I'll try to understand what you meant in the last email. > > As IMA_DONE_MASK contains all other bitmasks, it's possible to > optimize the code like this: > > if (test_and_clear_bit(IMA_CHANGE_XATTR, &iint->atomic_flags)) { > iint->flags &= ~IMA_DONE_MASK; > } else if (inode->i_sb->s_type->fs_flags & FS_IMA_NO_CACHE) { > iint->flags &= ~IMA_DONE_MASK; > if (action & IMA_MEASURE) > iint->measured_pcrs = 0; > } > > Is that what you want to see? Please let me know if it's not. > Tomorrow I will try to test with a new patch.
Today I created a new patch, and tested it. It worked fine. So I've just sent a new patchset v4. Please see: https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1598387.html
Thanks, Dongsu
> Thanks, > Dongsu > >> Mimi >>
| |