Messages in this thread | | | From | Rob Herring <> | Date | Tue, 30 Jan 2018 08:44:28 -0600 | Subject | Re: [PATCH 4/4] rtc: isl1208: add support for isl1219 with hwmon for tamper detection |
| |
On Tue, Jan 30, 2018 at 8:41 AM, Rob Herring <robh@kernel.org> wrote: > On Tue, Jan 30, 2018 at 2:56 AM, Denis OSTERLAND > <denis.osterland@diehl.com> wrote: >> Am Montag, den 29.01.2018, 17:41 -0600 schrieb Rob Herring: >>> On Tue, Jan 23, 2018 at 01:18:01PM +0100, Michael Grzeschik wrote: >>> > >>> > We add support for the ISL1219 chip that got an integrated tamper >>> > detection function. This patch implements the feature by using an hwmon >>> > interface.
[...]
>>> There's not much point in having an example for every compatible. This >>> binding is simple enough, one should be enough. >> Shell we remove the example without an interrupt? > > The existing example has a single interrupt, right? That should be > enough. You just need to document for the interrupts property which > devices have 2 interrupts and what the order is.
Looking at the first patch now, yes you can drop the 1st example and just keep the 2nd example.
Rob
| |