lkml.org 
[lkml]   [2018]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Subject[PATCH 3/3] RDMA/iwpm: Improve a size determination in two functions
From
Date
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 27 Jan 2018 22:05:54 +0100

Replace the specification of data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/infiniband/core/iwpm_util.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/core/iwpm_util.c b/drivers/infiniband/core/iwpm_util.c
index 9eb527074c32..902a2677df31 100644
--- a/drivers/infiniband/core/iwpm_util.c
+++ b/drivers/infiniband/core/iwpm_util.c
@@ -121,7 +121,8 @@ int iwpm_create_mapinfo(struct sockaddr_storage *local_sockaddr,

if (!iwpm_valid_client(nl_client))
return ret;
- map_info = kzalloc(sizeof(struct iwpm_mapping_info), GFP_KERNEL);
+
+ map_info = kzalloc(sizeof(*map_info), GFP_KERNEL);
if (!map_info)
return -ENOMEM;

@@ -298,7 +299,7 @@ struct iwpm_nlmsg_request *iwpm_get_nlmsg_request(__u32 nlmsg_seq,
struct iwpm_nlmsg_request *nlmsg_request = NULL;
unsigned long flags;

- nlmsg_request = kzalloc(sizeof(struct iwpm_nlmsg_request), gfp);
+ nlmsg_request = kzalloc(sizeof(*nlmsg_request), gfp);
if (!nlmsg_request)
return NULL;

--
2.16.1
\
 
 \ /
  Last update: 2018-01-27 22:21    [W:0.054 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site